Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757391AbaFYOLy (ORCPT ); Wed, 25 Jun 2014 10:11:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11307 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756873AbaFYOLw (ORCPT ); Wed, 25 Jun 2014 10:11:52 -0400 Date: Wed, 25 Jun 2014 10:10:52 -0400 From: Dave Jones To: Linus Torvalds Cc: Tom Herbert , David Miller , Andrew Morton , Network Development , Linux Kernel Mailing List Subject: Re: [PATCH] tcp: fix setting csum_start in tcp_gso_segment Message-ID: <20140625141052.GA1096@redhat.com> Mail-Followup-To: Dave Jones , Linus Torvalds , Tom Herbert , David Miller , Andrew Morton , Network Development , Linux Kernel Mailing List References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 24, 2014 at 09:17:25PM -0700, Linus Torvalds wrote: > On Tue, Jun 24, 2014 at 9:03 PM, Tom Herbert wrote: > > > > It looks like a likely culprit is that SKB_GSO_CB()->csum_start is > > not set correctly when doing non-scatter gather. We are using > > offset as opposed to doffset. > > > > Reported-by: Dave Jones > > DaveJ, I think you triggered this in five minutes on your box, and I > don't recall seeing anybody else reporting the oops (and google > doesn't find anything in the last month). So it's presumably somewhat > hw-specific. Does this fix the problem? It's survived routing ~1GB of packets overnight, so I'd call this good. thanks Tom. Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/