Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757158AbaFYOoS (ORCPT ); Wed, 25 Jun 2014 10:44:18 -0400 Received: from mail-oa0-f50.google.com ([209.85.219.50]:33038 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756454AbaFYOoP (ORCPT ); Wed, 25 Jun 2014 10:44:15 -0400 MIME-Version: 1.0 In-Reply-To: <20140625134354.GA7892@redhat.com> References: <1403642893-23107-1-git-send-email-keescook@chromium.org> <1403642893-23107-5-git-send-email-keescook@chromium.org> <20140625134354.GA7892@redhat.com> Date: Wed, 25 Jun 2014 07:44:15 -0700 X-Google-Sender-Auth: 0nCLCSOhkNigsvazxcb0T8pkDus Message-ID: Subject: Re: [PATCH v8 4/9] sched: move no_new_privs into new atomic flags From: Kees Cook To: Oleg Nesterov Cc: LKML , Andy Lutomirski , "Michael Kerrisk (man-pages)" , Alexei Starovoitov , Andrew Morton , Daniel Borkmann , Will Drewry , Julien Tinnes , David Drysdale , Linux API , "x86@kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mips@linux-mips.org, linux-arch , linux-security-module Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 25, 2014 at 6:43 AM, Oleg Nesterov wrote: > On 06/24, Kees Cook wrote: >> >> --- a/include/linux/sched.h >> +++ b/include/linux/sched.h >> @@ -1307,8 +1307,7 @@ struct task_struct { >> * execve */ >> unsigned in_iowait:1; >> >> - /* task may not gain privileges */ >> - unsigned no_new_privs:1; >> + unsigned long atomic_flags; /* Flags needing atomic access. */ >> >> /* Revert to default priority/policy when forking */ >> unsigned sched_reset_on_fork:1; > > Agreed, personally I like it more than seccomp->flags. > > But probably it would be better to place the new member before/after > other bitfields to save the space? Sure, I'll move it down. (Though I thought the compiler was smarter about that.) -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/