Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757430AbaFYO4j (ORCPT ); Wed, 25 Jun 2014 10:56:39 -0400 Received: from mail-qa0-f44.google.com ([209.85.216.44]:36767 "EHLO mail-qa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757232AbaFYO4h (ORCPT ); Wed, 25 Jun 2014 10:56:37 -0400 Date: Wed, 25 Jun 2014 10:56:34 -0400 From: Tejun Heo To: Benjamin LaHaise Cc: cl@linux-foundation.org, kmo@daterainc.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] percpu-refcount, aio: use percpu_ref_cancel_init() in ioctx_alloc() Message-ID: <20140625145634.GD26883@htj.dyndns.org> References: <1403053685-28240-1-git-send-email-tj@kernel.org> <1403053685-28240-2-git-send-email-tj@kernel.org> <20140625143112.GR23137@kvack.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140625143112.GR23137@kvack.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Benjamin. On Wed, Jun 25, 2014 at 10:31:12AM -0400, Benjamin LaHaise wrote: > On Tue, Jun 17, 2014 at 09:08:00PM -0400, Tejun Heo wrote: > > ioctx_alloc() reaches inside percpu_ref and directly frees > > ->pcpu_count in its failure path, which is quite gross. percpu_ref > > has been providing a proper interface to do this, > > percpu_ref_cancel_init(), for quite some time now. Let's use that > > instead. > > I applied this to my aio-next tree at git://git.kvack.org/~bcrl/aio-next.git . It'd probably easier if I route this through percpu tree with the rest of changes as there are further changes on the aio side (trivial but still), so we'd end up having to do pulling dance back and forth. The changes on aio side are mostly trivial. Can I route them through percpu tree with your acks? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/