Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757602AbaFYQl3 (ORCPT ); Wed, 25 Jun 2014 12:41:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47563 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756944AbaFYQl1 (ORCPT ); Wed, 25 Jun 2014 12:41:27 -0400 Message-ID: <1403714445.755.112.camel@deneb.redhat.com> Subject: Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support. From: Mark Salter To: Dann Frazier Cc: Iyappan Subramanian , davem@davemloft.net, netdev@vger.kernel.org, "devicetree@vger.kernel.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, jcm@redhat.com, patches@apm.com, Ravi Patel , Keyur Chudgar Date: Wed, 25 Jun 2014 12:40:45 -0400 In-Reply-To: References: <1403306296-26198-1-git-send-email-isubramanian@apm.com> <1403306296-26198-5-git-send-email-isubramanian@apm.com> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-06-24 at 22:29 -0600, Dann Frazier wrote: > On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian > > + ring->desc_addr = dma_zalloc_coherent(dev, size, &ring->dma, > > + GFP_KERNEL); > > Iyappan, > When testing this driver on a 3.16-rc2 base, I'm finding that > desc_addr gets assigned to NULL here, which results in an oops later > on (see below). > > I wasn't seeing this before (3.15 base), so I'm guessing something > changed upstream, or in my config, to change this behavior. But it > does illuminate a place where we could maybe use some better error > handling (also see below). https://lkml.org/lkml/2014/6/23/10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/