Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754369AbaFYTye (ORCPT ); Wed, 25 Jun 2014 15:54:34 -0400 Received: from mail-ve0-f179.google.com ([209.85.128.179]:55493 "EHLO mail-ve0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751419AbaFYTyc (ORCPT ); Wed, 25 Jun 2014 15:54:32 -0400 MIME-Version: 1.0 In-Reply-To: <1403723019-6212-5-git-send-email-javier.martinez@collabora.co.uk> References: <1403723019-6212-1-git-send-email-javier.martinez@collabora.co.uk> <1403723019-6212-5-git-send-email-javier.martinez@collabora.co.uk> Date: Wed, 25 Jun 2014 12:54:31 -0700 X-Google-Sender-Auth: r3zDSFyp8M-F574VKH_u60DbpjI Message-ID: Subject: Re: [PATCH v4 04/14] clk: max77686: Improve Maxim 77686 PMIC clocks binding From: Doug Anderson To: Javier Martinez Canillas Cc: Lee Jones , Samuel Ortiz , Mark Brown , Mike Turquette , Liam Girdwood , Alessandro Zummo , Kukjin Kim , Olof Johansson , Sjoerd Simons , Daniel Stone , Tomeu Vizoso , Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , linux-samsung-soc , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Javier, On Wed, Jun 25, 2014 at 12:03 PM, Javier Martinez Canillas wrote: > Like most clock drivers, the Maxim 77686 PMIC clock binding > follows the convention that the "#clock-cells" property is > used to specify the number of cells in a clock provider. > > But the binding document is not clear enough that it shall > be set to 1 since the PMIC support multiple clocks outputs. > > Also, explain that the clocks identifiers are defined in a > header file that can be included by Device Tree source with > client nodes to avoid using magic numbers. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > --- > > Changes since v3: > - Don't change clock-names property to make clear that it's > the consumer clock name and should not match the producer clock. > Suggested by Doug Anderson. > > Documentation/devicetree/bindings/clock/maxim,max77686.txt | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) Reviewed-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/