Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbaFYUin (ORCPT ); Wed, 25 Jun 2014 16:38:43 -0400 Received: from mail.skyhub.de ([78.46.96.112]:48574 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753174AbaFYUim (ORCPT ); Wed, 25 Jun 2014 16:38:42 -0400 Date: Wed, 25 Jun 2014 22:38:36 +0200 From: Borislav Petkov To: Jiri Olsa , Arnaldo Carvalho de Melo Cc: LKML , Ingo Molnar , Peter Zijlstra , Robert Richter , David Ahern , Namhyung Kim , Jean Pihet Subject: Re: [PATCH] perf tool: Carve out ctype.h et al Message-ID: <20140625203836.GD13845@pd.tnic> References: <1403688184-6917-1-git-send-email-bp@alien8.de> <20140625192547.GF1153@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140625192547.GF1153@krava.brq.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 25, 2014 at 09:25:47PM +0200, Jiri Olsa wrote: > heya, > got following error; > > [jolsa@krava perf]$ make > BUILD: Doing 'make -j4' parallel build > CC util/pmu.o > CC util/parse-events-flex.o > SUBDIR /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/ > util/pmu.c: In function ‘wordwrap’: > util/pmu.c:788:3: error: implicit declaration of function ‘isspace’ [-Werror=implicit-function-declaration] > while (isspace(*s)) > ^ > cc1: all warnings being treated as errors > make[1]: *** [util/pmu.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [all] Error 2 This is a perfect example why doing this piecewise is the only way to go! And even that is not easy: I don't have this line in util/pmu.c:788 so I can't trigger it: 782 bool pmu_have_event(const char *pname, const char *name) 783 { 784 struct perf_pmu *pmu; 785 struct perf_pmu_alias *alias; 786 787 pmu = NULL; 788 while ((pmu = perf_pmu__scan(pmu)) != NULL) { 789 if (strcmp(pname, pmu->name)) 790 continue; 791 list_for_each_entry(alias, &pmu->aliases, list) 792 if (!strcmp(alias->name, name)) 793 return true; 794 } 795 return false; 796 } So, I've done the patch ontop of those branches: commit 279a8cc64fada4b0e7ebf4e4631d67c8ca715f27 Merge: 9724066c49ba 1545d8aca9ac Author: Borislav Petkov Date: Tue Jun 24 15:45:51 2014 +0200 Merge remote-tracking branch 'jolsa/perf/core' into ptool-v0.5 commit 9724066c49baab314a0c3d3f84ec102cd0f76b86 Merge: ecdac96899e3 a93f0e551af9 Author: Borislav Petkov Date: Tue Jun 24 15:45:44 2014 +0200 Merge remote-tracking branch 'jolsa/perf/urgent' into ptool-v0.5 commit a93f0e551af9e194db38bfe16001e17a3a1d189a Author: Simon Que Date: Mon Jun 16 11:32:09 2014 -0700 perf symbols: Get kernel start address by symbol name by checking out acme/perf/core first. So, guys, can we agree on a common branch to apply patches ontop please? Thanks a lot. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/