Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756632AbaFYVq1 (ORCPT ); Wed, 25 Jun 2014 17:46:27 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:38473 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755544AbaFYVqZ (ORCPT ); Wed, 25 Jun 2014 17:46:25 -0400 Message-ID: <53AB432A.7010400@wwwdotorg.org> Date: Wed, 25 Jun 2014 15:46:18 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andrew Bresticker , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Thierry Reding , Russell King , Linus Walleij , Greg Kroah-Hartman , Mathias Nyman , Grant Likely , Alan Stern , Kishon Vijay Abraham I , Arnd Bergmann Subject: Re: [PATCH v1 3/9] of: Update Tegra XUSB pad controller binding for USB References: <1403072180-4944-1-git-send-email-abrestic@chromium.org> <1403072180-4944-4-git-send-email-abrestic@chromium.org> In-Reply-To: <1403072180-4944-4-git-send-email-abrestic@chromium.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2014 12:16 AM, Andrew Bresticker wrote: > Add new bindings used for USB support by the Tegra XUSB pad controller. > This includes additional PHY types, USB-specific pinconfig properties, etc. > diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt > @@ -21,6 +21,12 @@ Required properties: > - padctl > - #phy-cells: Should be 1. The specifier is the index of the PHY to reference. > See for the list of valid values. > +- nvidia,xusb-mbox: Handle to the Tegra XUSB mailbox node. Why does the padctrl code need access to the XUSB mailbox? Isn't the padctrl HW module something that provides services to the XUSB code. I would have expected the XUSB node to reference the padctrl node. If notifications need to be sent back from XUSB padctrl to XUSB, then that seems like an internal SW detail that doesn't need to be represented in DT. > +Optional properties: > +------------------- > +- vbus-otg-{0,1,2}-supply: VBUS regulator for the corresponding UTMI pad. Isn't VBUS something that's controlled by the USB PHY? I think the PHYs are part of the XUSB controller, whereas the XUSB pad control is just the low level IO pad HW. > +- nvidia,usb3-port-num: USB3 port (0 or 1) to which the lane is mapped. > +- nvidia,usb2-port-num: USB2 port (0, 1, or 2) to which the lane is mapped. > +- nvidia,hsic-strobe-trim: HSIC strobe trimmer value. > +- nvidia,hsic-rx-strobe-trim: HSIC RX strobe trimmer value. > +- nvidia,hsic-rx-data-trim: HSIC RX data trimmer value. > +- nvidia,hsic-tx-rtune-n: HSIC TX RTUNEN value. > +- nvidia,hsic-tx-rtune-p: HSIC TX RTUNEP value. > +- nvidia,hsic-tx-slew-n: HSIC TX SLEWN value. > +- nvidia,hsic-tx-slew-p: HSIC TX SLEWP value. > +- nvidia,hsic-auto-term: Enables HSIC AUTO_TERM. (0: no, 1: yes) I wonder if some of that isn't part of the PHY not the pads? > Valid functions for this group are: "snps", "xusb", "uart", "rsvd". > > - The nvidia,iddq property does not apply to this group. > + The nvidia,iddq, nvidia,usb3-port-num, nvidia,usb2-port-num, and > + nvidia,hsic-* properties do not apply to this group. Given the increased number of properties we now have, it seems better to list the properties that *do* apply to each group, rather than those that don't. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/