Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756790AbaFYVw3 (ORCPT ); Wed, 25 Jun 2014 17:52:29 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:41369 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754214AbaFYVw0 (ORCPT ); Wed, 25 Jun 2014 17:52:26 -0400 Message-ID: <53AB4495.1020000@wwwdotorg.org> Date: Wed, 25 Jun 2014 15:52:21 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Andrew Bresticker , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org CC: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Thierry Reding , Russell King , Linus Walleij , Greg Kroah-Hartman , Mathias Nyman , Grant Likely , Alan Stern , Kishon Vijay Abraham I , Arnd Bergmann Subject: Re: [PATCH v1 5/9] of: Add NVIDIA Tegra XHCI controller binding References: <1403072180-4944-1-git-send-email-abrestic@chromium.org> <1403072180-4944-6-git-send-email-abrestic@chromium.org> In-Reply-To: <1403072180-4944-6-git-send-email-abrestic@chromium.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/18/2014 12:16 AM, Andrew Bresticker wrote: > Add device-tree binding documentation for the XHCI controller present > on Tegra124 and later SoCs. > diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xhci.txt > +Required properties: > +-------------------- > + - clock-names: Must include the following entries: > + - xusb_host > + - xusb_falcon_src > + - xusb_ss > + - xusb_ss_src > + - xusb_hs_src > + - xusb_fs_src > + - pll_u_480m > + - clk_m > + - pll_e > + - reset-names: Must include the following entries: > + - xusb_host > + - xusb_ss Usually the CAR has a reset control for each clock. So, I would expect as many entries in reset-names as in clock-names. Even if the SW doesn't currently touch all the reset lines, we should make sure the binding requires them to be present so that any DT will contain the entries if they're ever needed in the future. In the CAR documentation, I see "XUSB_DEV" as a clock/reset bit. Is that missing from the list above? > + - nvidia,xusb-mbox: Handle to the Tegra XUSB mailbox node. As mentioned earlier, I think that's an internal implementation detail. Shouldn't the two nodes be squashed together? > +Optional properties: > + - s1p05v-supply: 1.05V supply regulator. > + - s1p8v-supply: 1.8V supply regulator. > + - s3p3v-supply: 3.3V supply regulator. What are those supplies for? I would have expected any input to the SoC to have a name that described its purpose, and the pins and DT properties would be named to match. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/