From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
        "H. Peter Anvin" <hpa@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts/mod/modpost.c: Fix bug in number_prefix
Organization: D03
References: <1403685999-31013-1-git-send-email-linux@rasmusvillemoes.dk>
	<53AADC30.7080401@windriver.com>
Date: Thu, 26 Jun 2014 00:57:33 +0200
In-Reply-To: <53AADC30.7080401@windriver.com> (Paul Gortmaker's message of
	"Wed, 25 Jun 2014 10:26:56 -0400")
Message-ID: <8761jooaw2.fsf@rasmusvillemoes.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org

Paul Gortmaker <paul.gortmaker@windriver.com> writes:

> On 14-06-25 04:46 AM, Rasmus Villemoes wrote:
>> The function number_prefix() can currently only return 1 if its
>> argument is the empty string: If line 3 is reached and *sym (now the
>> second character in the argument) is not '.', 0 is returned. However,
>> if that character is '.', the first assignment to c is that same '.',
>> which obviously fails to be a digit.
>
> I'd suggest you expand the commit log to actually list the end-user
> visible symptom and the use case that this actually fixes, since it
> isn't obvious to me at all.

Sorry, it isn't obvious to me either. I just stumbled on it reading the
code; the rest of modpost.c is too deep magic for me.

Maybe there are no user-visible symptoms, and maybe that means it is not
worth fixing, in which case I'll just add scripts/mod/modpost.c to my
mental .ocpdignore.

Thanks,
Rasmus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/