Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756256AbaFYXH5 (ORCPT ); Wed, 25 Jun 2014 19:07:57 -0400 Received: from mail-vc0-f170.google.com ([209.85.220.170]:54679 "EHLO mail-vc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbaFYXHx (ORCPT ); Wed, 25 Jun 2014 19:07:53 -0400 MIME-Version: 1.0 In-Reply-To: <53AB46E0.5010908@wwwdotorg.org> References: <1403072180-4944-1-git-send-email-abrestic@chromium.org> <1403072180-4944-3-git-send-email-abrestic@chromium.org> <53AB46E0.5010908@wwwdotorg.org> Date: Wed, 25 Jun 2014 16:07:53 -0700 X-Google-Sender-Auth: eeWvOkEKIoaOgkxapZJa8UGtms4 Message-ID: Subject: Re: [PATCH v1 2/9] mailbox: Add NVIDIA Tegra XUSB mailbox driver From: Andrew Bresticker To: Stephen Warren Cc: devicetree@vger.kernel.org, linux-doc@vger.kernel.org, "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-usb@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Thierry Reding , Russell King , Linus Walleij , Greg Kroah-Hartman , Mathias Nyman , Grant Likely , Alan Stern , Kishon Vijay Abraham I , Arnd Bergmann Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 25, 2014 at 3:02 PM, Stephen Warren wrote: > On 06/18/2014 12:16 AM, Andrew Bresticker wrote: >> The Tegra XHCI controller communicates requests to the host through >> a mailbox interface. Host drivers which can handle these requests, >> such as the Tegra XUSB pad controller driver and upcoming Tegra XHCI >> host controller driver, can send messages and register to be notified >> of incoming messages. > >> diff --git a/include/linux/tegra-xusb-mbox.h b/include/linux/tegra-xusb-mbox.h > >> +extern int tegra_xusb_mbox_register_notifier(struct tegra_xusb_mbox *mbox, >> + struct notifier_block *nb); >> +extern void tegra_xusb_mbox_unregister_notifier(struct tegra_xusb_mbox *mbox, >> + struct notifier_block *nb); >> +extern int tegra_xusb_mbox_send(struct tegra_xusb_mbox *mbox, >> + enum tegra_xusb_mbox_cmd cmd, u32 data); >> +extern struct tegra_xusb_mbox * >> +tegra_xusb_mbox_lookup_by_phandle(struct device_node *np, const char *prop); > > This seems to use a custom API. I've seen mention of a mailbox > subsystem, and I assume that has a standardized API. Should this driver > implement that instead? All the mailbox drivers currently use a custom API, but there is indeed a patch series floating around to create a generic mailbox framework, though it hasn't landed in -next yet. I can take a look at how this driver would fit into that framework. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/