Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752367AbaFZE7D (ORCPT ); Thu, 26 Jun 2014 00:59:03 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:42234 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbaFZE7B (ORCPT ); Thu, 26 Jun 2014 00:59:01 -0400 MIME-Version: 1.0 In-Reply-To: References: <1403692697-7381-1-git-send-email-ch.naveen@samsung.com> <1403692697-7381-2-git-send-email-ch.naveen@samsung.com> From: Naveen Krishna Ch Date: Thu, 26 Jun 2014 10:28:39 +0530 Message-ID: Subject: Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits To: Sachin Kamat Cc: Naveen Krishna Chatradhi , linux-samsung-soc , linux-i2c@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , sjg@chromium.org, open list , Wolfram Sang , cpgs@samsung.com, broonie@kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Sachin, On 25 June 2014 16:19, Sachin Kamat wrote: > Hi Naveen, > > On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi > wrote: >> This patch removes an extra line and fixes a styling nit >> in exynos5_i2c_message_start() >> >> Signed-off-by: Naveen Krishna Chatradhi >> --- >> drivers/i2c/busses/i2c-exynos5.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c >> index 0d1a7bc..4c2e6f3 100644 >> --- a/drivers/i2c/busses/i2c-exynos5.c >> +++ b/drivers/i2c/busses/i2c-exynos5.c >> @@ -525,7 +525,7 @@ static void exynos5_i2c_message_start(struct exynos5_i2c *i2c, int stop) >> if (i2c->msg->flags & I2C_M_RD) { >> i2c_ctl |= HSI2C_RXCHON; >> >> - i2c_auto_conf = HSI2C_READ_WRITE; >> + i2c_auto_conf |= HSI2C_READ_WRITE; > > This change looks more than just a styling nit. Please update the commit message > accordingly. Yea, change looks so. But, This is not an going to change the way code works. As, i2c_auto_conf is initialized to '0' at the beginning of the function and HSI2C_READ_WRITE is defined as (1u << 16) This being the 1st usage, I thought using "|=" is better way of assignment. Will edit the commit message accordingly. > > -- > Regards, > Sachin. Thanks, -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/