Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755176AbaFZHej (ORCPT ); Thu, 26 Jun 2014 03:34:39 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:53288 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754709AbaFZHeg (ORCPT ); Thu, 26 Jun 2014 03:34:36 -0400 MIME-Version: 1.0 In-Reply-To: <53AB1CC1.4010907@codeaurora.org> References: <53AB1CC1.4010907@codeaurora.org> Date: Thu, 26 Jun 2014 13:04:35 +0530 Message-ID: Subject: Re: [PATCH 2/2] cpufreq: cpu0: Extend support beyond CPU0 From: Viresh Kumar To: Stephen Boyd , Mark Brown Cc: "Rafael J. Wysocki" , Shawn Guo , Lists linaro-kernel , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Arvind Chauhan , Mike Turquette , "linux-arm-kernel@lists.infradead.org" , linux-arm-msm@vger.kernel.org, Sachin Kamat , Thomas P Abraham , Nishanth Menon , Tomasz Figa , Mark Rutland Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26 June 2014 00:32, Stephen Boyd wrote: >> + cpu_reg = regulator_get_optional(cpu_dev, "cpu0"); > I don't think this driver should be using regulator_get_optional() (Mark > B. please correct me if I'm wrong). I doubt a supply is actually > optional for CPUs, just some DTs aren't specifying them. In those cases, > the regulator core will insert a dummy supply and the code will work > without having to check for probe defer and error pointers. This is what Mark did earlier, don't know if he would like to revert it: 7d74897 (cpufreq: cpufreq-cpu0: Use devm_regulator_get_optional()). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/