Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756528AbaFZKcO (ORCPT ); Thu, 26 Jun 2014 06:32:14 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:15633 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755984AbaFZKcN (ORCPT ); Thu, 26 Jun 2014 06:32:13 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 26 Jun 2014 03:22:18 -0700 Date: Thu, 26 Jun 2014 13:32:09 +0300 From: Peter De Schrijver To: Mike Turquette CC: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] clk: define and export __clk_get_debug for providers Message-ID: <20140626103209.GC3679@tbergstrom-lnx.Nvidia.com> References: <1403713591-17179-1-git-send-email-pdeschrijver@nvidia.com> <44039675.8s16pHQIVH@wuerfel> <20140625182349.32686.25931@quantum> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20140625182349.32686.25931@quantum> X-NVConfidentiality: public User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 25, 2014 at 08:23:49PM +0200, Mike Turquette wrote: > Quoting Arnd Bergmann (2014-06-25 11:07:37) > > On Wednesday 25 June 2014 19:26:31 Peter De Schrijver wrote: > > > Define and export a new function __clk_get_debug which returns the debugfs > > > directory entry pointer. This can be used by clock providers to add debugfs > > > entries which are not related to a specific clock type. Examples include the > > > ability to measure the rate of a clock. It can also be used by modules to > > > create new debugfs entries. This is useful if you want to expose features > > > for testing which can potentially cause system instability such as allowing > > > to change a clock's rate from userspace. > > > > > > Signed-off-by: Peter De Schrijver > > > > > > > Just an idea, but would it be better to add a pair of functions to add/remove > > debugfs files rather than exposing the dentry itself? > > Arnd, > > Yes, accessor functions are much better than exposing struct clk > internals. > > Peter, > > Just FYI, I'm trying to reverse the trend of prepending double > underscores for functions that are used by clock providers. That stuff > started out small and sort of grew out of control ;-) > Ah. I was just following the existing pattern here :) Cheers, Peter. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/