Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757234AbaFZLaL (ORCPT ); Thu, 26 Jun 2014 07:30:11 -0400 Received: from mail-wg0-f43.google.com ([74.125.82.43]:40270 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756280AbaFZLaI (ORCPT ); Thu, 26 Jun 2014 07:30:08 -0400 From: Rickard Strandqvist To: Linus Walleij , linux-kernel@vger.kernel.org Cc: Rickard Strandqvist Subject: [PATCH] pinctrl: pinctrl-msm.c: Cleaning up if unsigned is less than zero Date: Thu, 26 Jun 2014 13:31:19 +0200 Message-Id: <1403782279-10116-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove checking if a unsigned is less than zero This was found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/pinctrl/pinctrl-msm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-msm.c b/drivers/pinctrl/pinctrl-msm.c index df6dda4c..cde8b2b 100644 --- a/drivers/pinctrl/pinctrl-msm.c +++ b/drivers/pinctrl/pinctrl-msm.c @@ -176,7 +176,7 @@ static void msm_pinmux_disable(struct pinctrl_dev *pctldev, g = &pctrl->soc->groups[group]; - if (WARN_ON(g->mux_bit < 0)) + if (WARN_ON(g->mux_bit != 0)) return; spin_lock_irqsave(&pctrl->lock, flags); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/