From: KY Srinivasan <kys@microsoft.com>
To: "Yue Zhang (OSTC DEV)" <yuezha@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "driverdev-devel@linuxdriverproject.org" 
	<driverdev-devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "apw@canonical.com" <apw@canonical.com>
CC: Dexuan Cui <decui@microsoft.com>, Thomas Shao <huishao@microsoft.com>
Subject: RE: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon
Thread-Topic: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon
Thread-Index: AQHPkXqZAHj0PqEENkSegLhluqQpVJuD2uTw
Date: Thu, 26 Jun 2014 20:43:46 +0000
Message-ID: <9aa07d3dad7c448da7ee7a3e007e0140@BY2PR03MB299.namprd03.prod.outlook.com>
References: <1403816968-15419-1-git-send-email-yuezha@microsoft.com>
In-Reply-To: <1403816968-15419-1-git-send-email-yuezha@microsoft.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org


> -----Original Message-----
> From: Yue Zhang [mailto:yuezha@microsoft.com]
> Sent: Thursday, June 26, 2014 2:09 PM
> To: KY Srinivasan; Haiyang Zhang; driverdev-devel@linuxdriverproject.org;
> linux-kernel@vger.kernel.org; olaf@aepfle.de; jasowang@redhat.com;
> apw@canonical.com
> Cc: Dexuan Cui; Thomas Shao
> Subject: [PATCH] Tools: hv: fix file overwriting of hv_fcopy_daemon
> 
> From: Yue Zhang <yuezha@microsoft.com>
> 
> hv_fcopy_daemon fails to overwrite a file if the target file already exits.
> 
> Add O_TRUNC flag on opening.
> 
> Signed-off-by: Yue Zhang <yuezha@microsoft.com>
> ---
>  tools/hv/hv_fcopy_daemon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
> index fba1c75..01eee6b 100644
> --- a/tools/hv/hv_fcopy_daemon.c
> +++ b/tools/hv/hv_fcopy_daemon.c
> @@ -88,7 +88,8 @@ static int hv_start_fcopy(struct hv_start_fcopy *smsg)
>  		}
>  	}
> 
> -	target_fd = open(target_fname, O_RDWR | O_CREAT | O_CLOEXEC,
> 0744);
> +	target_fd = open(target_fname,
> +				O_RDWR | O_CREAT | O_TRUNC |
Please align O_RDWR to align with the first argument (target_fname). 

K. Y

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/