Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbaFZVvJ (ORCPT ); Thu, 26 Jun 2014 17:51:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33317 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbaFZVvH (ORCPT ); Thu, 26 Jun 2014 17:51:07 -0400 Date: Thu, 26 Jun 2014 14:51:06 -0700 From: Andrew Morton To: Shuah Khan Cc: gregkh@linuxfoundation.org, keescook@chromium.org, michael@ellerman.id.au, fweisbec@gmail.com, benh@kernel.crashing.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools: selftests - create a separate hotplug target Message-Id: <20140626145106.83d8a15bfa07270b00e5d24b@linux-foundation.org> In-Reply-To: <1403814836-16964-1-git-send-email-shuah.kh@samsung.com> References: <1403814836-16964-1-git-send-email-shuah.kh@samsung.com> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Jun 2014 14:33:56 -0600 Shuah Khan wrote: > On some systems, hotplug tests could hang forever waiting for cpu and > memory to be ready to be offlined. A special hotplug target is created, > which will help run non-hotplug tests and run hotplug tests as a special > case. Individual hotplug tests can still be run as a special target > targeted for a single subsystem. This is a bit sad. The general philosophy with selftests is that they should run to completion even if the kernel/hardware which they are testing isn't available - they should work it out for themselves. But that's obviously a problem with hotplug. And with networking or anything else which needs external action. On the other hand, networking has loopback and the kernel supports cpu hotplug simulation via procfs. So perhaps the cpu and memory hotplug tests should be redone so they do the plug/unplug injection themselves, so they can run without external intervention? Failing that, all I can think of is timeouts or some silly "press any key to continue" operator intervention. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/