Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849AbaFZV4c (ORCPT ); Thu, 26 Jun 2014 17:56:32 -0400 Received: from mail-ig0-f179.google.com ([209.85.213.179]:51775 "EHLO mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbaFZV4a (ORCPT ); Thu, 26 Jun 2014 17:56:30 -0400 Date: Thu, 26 Jun 2014 14:56:28 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Chen Gang cc: Lennox Wu , Guenter Roeck , Liqin Chen , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3] arch/score/include/uapi/asm/ptrace.h: Remove the macros which not be used currently In-Reply-To: <53AC10CB.3000007@gmail.com> Message-ID: References: <53AC10CB.3000007@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 26 Jun 2014, Chen Gang wrote: > 'COUNTER' and other same kind macros are too common to use, and easy to > get conflict with other modules. > > At present, they are not used, so it is OK to simply remove them. And the > related warning (allmodconfig with score): > > CC [M] drivers/md/raid1.o > In file included from drivers/md/raid1.c:42:0: > drivers/md/bitmap.h:93:0: warning: "COUNTER" redefined > #define COUNTER(x) (((bitmap_counter_t) x) & COUNTER_MAX) > ^ > In file included from ./arch/score/include/asm/ptrace.h:4:0, > from include/linux/sched.h:31, > from include/linux/blkdev.h:4, > from drivers/md/raid1.c:36: > ./arch/score/include/uapi/asm/ptrace.h:13:0: note: this is the location of the previous definition > #define COUNTER 38 > > > Signed-off-by: Chen Gang Acked-by: David Rientjes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/