Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbaF0JbZ (ORCPT ); Fri, 27 Jun 2014 05:31:25 -0400 Received: from bby1mta02.pmc-sierra.com ([216.241.235.117]:40387 "EHLO bby1mta02.pmc-sierra.bc.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752652AbaF0JbY convert rfc822-to-8bit (ORCPT ); Fri, 27 Jun 2014 05:31:24 -0400 X-Greylist: delayed 1474 seconds by postgrey-1.27 at vger.kernel.org; Fri, 27 Jun 2014 05:31:24 EDT From: Suresh Thiagarajan To: Jack Wang , Rickard Strandqvist CC: "lindar_liu@usish.com" , "James E.J. Bottomley" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once Thread-Topic: [PATCH] scsi: pm8001: pm80xx_hwi.c: Cleaning up variable is set more than once Thread-Index: AQHPkH3l8ZEfYWLRc0SQD33RbsdVb5uDgCIAgAEpYIA= Date: Fri, 27 Jun 2014 09:06:49 +0000 Message-ID: References: <1403704907-25672-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <53ABD51C.5050806@gmail.com> In-Reply-To: <53ABD51C.5050806@gmail.com> Accept-Language: en-US, en-CA Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [216.241.227.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 26, 2014 at 1:50 PM, Maurizio Lombardi wrote: > On 06/26/2014 10:09 AM, Jack Wang wrote: >> Thanks Rickard, >> >> From my point of view, looks good, but I'd like to get review from Anand >> (cc-ed). > > I would like to add that I noticed that this fields is only set and appears to be never used, > maybe it could be completely removed. You are correct. The whole forensic_info structure itself is not used or referred anywhere. I will remove it and send a patch. Regards, Suresh Thiagarajan > > Regards, > Maurizio Lombardi > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/