Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753485AbaF0Lru (ORCPT ); Fri, 27 Jun 2014 07:47:50 -0400 Received: from mail-qg0-f50.google.com ([209.85.192.50]:49127 "EHLO mail-qg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752826AbaF0Lrc (ORCPT ); Fri, 27 Jun 2014 07:47:32 -0400 MIME-Version: 1.0 In-Reply-To: <20140605115714.GA2294@griffinp-ThinkPad-X1-Carbon-2nd> References: <1401892320-18211-1-git-send-email-gabriel.fernandez@linaro.org> <1401892320-18211-6-git-send-email-gabriel.fernandez@linaro.org> <20140605115714.GA2294@griffinp-ThinkPad-X1-Carbon-2nd> Date: Fri, 27 Jun 2014 13:47:31 +0200 Message-ID: Subject: Re: [STLinux Kernel] [PATCH RESEND 05/12] drivers: clk: st: STiH407: Support for clockgenA0 From: Gabriel Fernandez To: Peter Griffin Cc: Gabriel FERNANDEZ , Mike Turquette , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree@vger.kernel.org" , "kernel@stlinux.com" , "linux-doc@vger.kernel.org" , Olivier Bideau , "linux-kernel@vger.kernel.org" , Lee Jones , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5 June 2014 13:57, Peter Griffin wrote: > Hi Gabi, > > On Wed, 04 Jun 2014, Gabriel FERNANDEZ wrote: > >> The patch added support for DT registration of ClockGenA0 >> It includes c32 type PLL. >> >> Signed-off-by: Gabriel Fernandez >> Signed-off-by: Olivier Bideau >> --- >> drivers/clk/st/clkgen-pll.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c >> index d8b9b1a..6916cfa 100644 >> --- a/drivers/clk/st/clkgen-pll.c >> +++ b/drivers/clk/st/clkgen-pll.c >> @@ -180,6 +180,18 @@ static struct clkgen_pll_data st_pll1200c32_gpu_416 = { >> .ops = &st_pll1200c32_ops, >> }; >> >> +static struct clkgen_pll_data st_pll3200c32_407_a0 = { >> + /* 407 A0 */ >> + .pdn_status = CLKGEN_FIELD(0x2a0, 0x1, 8), >> + .locked_status = CLKGEN_FIELD(0x2a0, 0x1, 24), >> + .ndiv = CLKGEN_FIELD(0x2a4, C32_NDIV_MASK, 16), >> + .idf = CLKGEN_FIELD(0x2a4, C32_IDF_MASK, 0x0), >> + .num_odfs = 1, >> + .odf = { CLKGEN_FIELD(0x2b4, C32_ODF_MASK, 0) }, >> + .odf_gate = { CLKGEN_FIELD(0x2b4, 0x1, 6) }, >> + .ops = &stm_pll3200c32_ops, >> +}; >> + >> /** > I think these could be 'static const' as well, with some fixups in the function protoypes > which use it. > Done Thanks Peter > Apart from that : - > Acked-by: Peter Griffin > > Regards, > > Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/