Date: Fri, 27 Jun 2014 10:39:33 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Petr =?UTF-8?B?TWzDoWRlaw==?= <pmladek@suse.cz>
Cc: linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jiri Kosina <jkosina@suse.cz>, Michal Hocko <mhocko@suse.cz>,
        Jan Kara <jack@suse.cz>, Frederic Weisbecker <fweisbec@gmail.com>,
        Dave Anderson <anderson@redhat.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Konstantin Khlebnikov <koct9i@gmail.com>
Subject: Re: [RFC][PATCH 4/5 v2] printk: Add per_cpu printk func to allow
 printk to be diverted
Message-ID: <20140627103933.1e7b981b@gandalf.local.home>
In-Reply-To: <20140627142025.GD23205@pathway.suse.cz>
References: <20140626214901.596791200@goodmis.org>
	<20140626220130.356038089@goodmis.org>
	<20140627142025.GD23205@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org

On Fri, 27 Jun 2014 16:20:25 +0200
Petr Mládek <pmladek@suse.cz> wrote:


> >  	va_start(args, fmt);
> > -	r = vprintk_emit(0, -1, NULL, 0, fmt, args);
> > +	preempt_disable();
> 
> I think that it is too late to disable the preemption here.
> It has to be done by the printk() caller if it wants to be sure
> that the requested function is used.

That's only if the printk() caller cares. But it would be nice that we
run the printk_func for the CPU that vprintk_func() is on, thus the
preempt_disable() is required. (in -rt, this would turn into a
migrate_disable()).

-- Steve

> 
> > +	vprintk_func = this_cpu_read(printk_func);
> > +	r = vprintk_func(fmt, args);
> > +	preempt_enable();
> >  	va_end(args);
> >  
> >  	return r;
> 
> Best Regards,
> Petr

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/