Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964912AbaF1R6j (ORCPT ); Sat, 28 Jun 2014 13:58:39 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:35582 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755415AbaF1R62 (ORCPT ); Sat, 28 Jun 2014 13:58:28 -0400 X-IronPort-AV: E=Sophos;i="5.01,567,1400018400"; d="scan'208";a="69376222" Date: Sat, 28 Jun 2014 19:58:13 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Fabian Frederick cc: linux-kernel@vger.kernel.org, Gilles Muller , Joe Perches , Andrew Morton , Michal Marek Subject: Re: [PATCH V3] scripts/coccinelle/free: add NULL test before freeing functions In-Reply-To: Message-ID: References: <1403945247-21549-1-git-send-email-fabf@skynet.be> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 28 Jun 2014, Julia Lawall wrote: > On Sat, 28 Jun 2014, Fabian Frederick wrote: > > > Warns or generates patch for NULL check before the following functions: > > > > kfree > > usb_free_urb > > debugfs_remove > > debugfs_remove_recursive > > > > Cc: Julia Lawall > > Cc: Gilles Muller > > Cc: Joe Perches > > Cc: Andrew Morton > > Signed-off-by: Fabian Frederick > > Acked-by: Julia Lawall > > > --- > > > > V3: > > -Update print_main message. > > -Add patch mode (suggested by Julia Lawall) > > > > V2: > > -Add 3 more functions to kfree (suggested by Joe Perches) > > -Update warning message to involve code analysis (suggested by Julia Lawall) > > > > scripts/coccinelle/free/ifnullfree.cocci | 53 ++++++++++++++++++++++++++++++++ > > 1 file changed, 53 insertions(+) > > create mode 100644 scripts/coccinelle/free/ifnullfree.cocci > > > > diff --git a/scripts/coccinelle/free/ifnullfree.cocci b/scripts/coccinelle/free/ifnullfree.cocci > > new file mode 100644 > > index 0000000..c826d98 > > --- /dev/null > > +++ b/scripts/coccinelle/free/ifnullfree.cocci > > @@ -0,0 +1,53 @@ > > +/// NULL check before some freeing functions is not needed. > > +/// > > +/// Based on checkpatch warning > > +/// "kfree(NULL) is safe this check is probably not required" > > +/// and kfreeaddr.cocci by Julia Lawall. > > +/// > > +/// Comments: - > > +/// Options: --no-includes --include-headers > > + > > +virtual patch > > +virtual org > > +virtual report > > +virtual context > > + > > +@r2 depends on patch@ > > +expression E; > > +@@ > > +- if (E) > > +( > > +- kfree(E); > > ++ kfree(E); > > +| > > +- debugfs_remove(E); > > ++ debugfs_remove(E); > > +| > > +- debugfs_remove_recursive(E); > > ++ debugfs_remove_recursive(E); > > +| > > +- usb_free_urb(E); > > ++ usb_free_urb(E); > > +) > > + > > +@r depends on context || report || org @ > > +expression E; > > +position p; > > +@@ > > + > > +* if (E) > > +* \(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E); > > + > > +@script:python depends on org@ > > +p << r.p; > > +@@ > > + > > +cocci.print_main("NULL check before that freeing function is not needed", p) > > + > > +@script:python depends on report@ > > +p << r.p; > > +@@ > > + > > +msg = "WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values." > > +coccilib.report.print_report(p[0], msg) > > + > > -- > > 1.8.4.5 > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/