Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753489AbaF2Tdx (ORCPT ); Sun, 29 Jun 2014 15:33:53 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:60544 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753413AbaF2Tdw (ORCPT ); Sun, 29 Jun 2014 15:33:52 -0400 Message-ID: <53B06A1F.9010105@codeaurora.org> Date: Sun, 29 Jun 2014 12:33:51 -0700 From: Laura Abbott User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Will Deacon CC: David Riley , Catalin Marinas , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , Ritesh Harjain , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCHv3 1/5] lib/genalloc.c: Add power aligned algorithm References: <1402969165-7526-1-git-send-email-lauraa@codeaurora.org> <1402969165-7526-2-git-send-email-lauraa@codeaurora.org> <20140620093340.GL25104@arm.com> In-Reply-To: <20140620093340.GL25104@arm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/20/2014 2:33 AM, Will Deacon wrote: > Hi Laura, > > On Tue, Jun 17, 2014 at 02:39:21AM +0100, Laura Abbott wrote: >> One of the more common algorithms used for allocation >> is to align the start address of the allocation to >> the order of size requested. Add this as an algorithm >> option for genalloc. > > Good idea, I didn't know this even existed! > >> Signed-off-by: Laura Abbott >> --- >> include/linux/genalloc.h | 4 ++++ >> lib/genalloc.c | 21 +++++++++++++++++++++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/include/linux/genalloc.h b/include/linux/genalloc.h >> index 1c2fdaa..3cd0934 100644 >> --- a/include/linux/genalloc.h >> +++ b/include/linux/genalloc.h >> @@ -110,6 +110,10 @@ extern void gen_pool_set_algo(struct gen_pool *pool, genpool_algo_t algo, >> extern unsigned long gen_pool_first_fit(unsigned long *map, unsigned long size, >> unsigned long start, unsigned int nr, void *data); >> >> +extern unsigned long gen_pool_first_fit_order_align(unsigned long *map, >> + unsigned long size, unsigned long start, unsigned int nr, >> + void *data); >> + >> extern unsigned long gen_pool_best_fit(unsigned long *map, unsigned long size, >> unsigned long start, unsigned int nr, void *data); >> >> diff --git a/lib/genalloc.c b/lib/genalloc.c >> index bdb9a45..9758529 100644 >> --- a/lib/genalloc.c >> +++ b/lib/genalloc.c >> @@ -481,6 +481,27 @@ unsigned long gen_pool_first_fit(unsigned long *map, unsigned long size, >> EXPORT_SYMBOL(gen_pool_first_fit); >> >> /** >> + * gen_pool_first_fit_order_align - find the first available region >> + * of memory matching the size requirement. The region will be aligned >> + * to the order of the size specified. >> + * @map: The address to base the search on >> + * @size: The bitmap size in bits >> + * @start: The bitnumber to start searching at >> + * @nr: The number of zeroed bits we're looking for >> + * @data: additional data - unused > > It doesn't look unused to me. > >> + */ >> +unsigned long gen_pool_first_fit_order_align(unsigned long *map, >> + unsigned long size, unsigned long start, >> + unsigned int nr, void *data) >> +{ >> + unsigned long order = (unsigned long) data; >> + unsigned long align_mask = (1 << get_order(nr << order)) - 1; > > Why isn't the order just order? > I did some bad math somewhere. All we really need is unsigned long align_mask = roundup_pow_of_two(nr) - 1; Which means the data would actually be unused. I'll fix it in the next version. Thanks, Laura -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/