MIME-Version: 1.0
In-Reply-To: <20140629212144.GA12303@kroah.com>
References: <20140627095226.GA9420@devel.8.8.4.4>
	<20140629212144.GA12303@kroah.com>
Date: Mon, 30 Jun 2014 14:40:50 +0900
Message-ID: <CAHb8M2BNTr_sbJYe0HdxvG6Wi8ozpTM6zo0K+ntZ8tHfPmGQrQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] staging: cxt1e1: Remove useless OS_phystov() and OS_vtophys()
From: DaeSeok Youn <daeseok.youn@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel <devel@driverdev.osuosl.org>, Shaun Laing <shaun@xresource.ca>,
        Wolfgang Ocker <weo@weo1.de>, "sachin.kamat" <sachin.kamat@linaro.org>,
        peter.p.waskiewicz.jr@intel.com,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Himangi Saraogi <himangi774@gmail.com>,
        Chekameh Cobbler <fempsci@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org

Hi, Greg.

2014-06-30 6:21 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> On Fri, Jun 27, 2014 at 06:52:26PM +0900, Daeseok Youn wrote:
>> OS_phystov()/OS_vtophys() are replaced with __va()/__pa().
>
> No, you should use virt_to_phys() and phys_to_virt() instead of these
> internal macros which might not be correct for all architectures.
OK, I will send this again after changing __pa/__va.
Thanks.

regards,
Daeseok Youn
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/