Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754140AbaF3FqS (ORCPT ); Mon, 30 Jun 2014 01:46:18 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:46791 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbaF3FqR (ORCPT ); Mon, 30 Jun 2014 01:46:17 -0400 MIME-Version: 1.0 In-Reply-To: <20140629212238.GA12439@kroah.com> References: <20140627095608.GA9427@devel.8.8.4.4> <20140629212238.GA12439@kroah.com> Date: Mon, 30 Jun 2014 14:46:17 +0900 Message-ID: Subject: Re: [PATCH 2/3] staging: cxt1e1: count fragmented packet properly. From: DaeSeok Youn To: Greg KH Cc: devel , Wolfgang Ocker , "sachin.kamat" , linux-kernel , Himangi Saraogi , Chekameh Cobbler Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-06-30 6:22 GMT+09:00 Greg KH : > On Fri, Jun 27, 2014 at 06:56:08PM +0900, Daeseok Youn wrote: >> OS_mem_token_tlen() is same return value as OS_mem_token_len(). >> That means packet count is always 1. So OS_mem_token_tlen() >> must be total length of packet and OS_mem_token_len() has a >> length of fragmented packet. And then it can count total >> count of fragmented packets properly. >> >> And OS_mem_token_next() returns NULL, it will be dereferencing >> a NULL pointer. So it must return next fragmented packet buffer as >> sk_buff. >> >> Signed-off-by: Daeseok Youn >> --- >> I'm not sure of this patch and not tested.(just only build test). >> Please review for this. >> Thanks. > > Please refresh these last two based on the changes in the first one you > should do. OK. I will sent these again after fixing 1/3. thanks. Daeseok Youn. > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/