Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755205AbaF3I4O (ORCPT ); Mon, 30 Jun 2014 04:56:14 -0400 Received: from mail1.skidata.com ([91.230.2.99]:19171 "EHLO mail1.skidata.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbaF3I4N (ORCPT ); Mon, 30 Jun 2014 04:56:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqEEAP4ksVOsEApK/2dsb2JhbABahDnFWQGBI3WEAwEBBAEnEz8FCwsNCAwlD0gGDgWIOg3GXhePBweEQwEEml2HMJASgi4 X-IPAS-Result: AqEEAP4ksVOsEApK/2dsb2JhbABahDnFWQGBI3WEAwEBBAEnEz8FCwsNCAwlD0gGDgWIOg3GXhePBweEQwEEml2HMJASgi4 Date: Mon, 30 Jun 2014 10:56:09 +0200 From: Richard Leitner To: David Laight CC: Greg Kroah-Hartman , Felipe Balbi , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX Message-ID: <20140630105609.66d4be83@lxbuild.skidata.net> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1726930B@AcuExch.aculab.com> References: <20140627133721.10ca6cab@lxbuild.skidata.net> <20140627174628.GA1449@kroah.com> <20140630083205.596557f1@lxbuild.skidata.net> <20140630103616.620a13a2@lxbuild.skidata.net> <063D6719AE5E284EB5DD2968C1650D6D1726930B@AcuExch.aculab.com> Organization: SKIDATA AG MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.16.60.30] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, 30 Jun 2014 08:41:18 +0000 David Laight wrote: > From: Of Richard Leitner > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > Due to the fact the strings are spread over different source files the > > PREFIX definition is moved to u_serial.h > > Lots of changes like: > > - DBG(cdev, "acm ttyGS%d completion, err %d\n", > > - acm->port_num, req->status); > > + DBG(cdev, "acm %s%d completion, err %d\n", > > + PREFIX, acm->port_num, req->status); > > I'm not sure this improves the code. Maybe you're right, the readability of the code wouldn't be better afterwards, but as I already mentioned IMHO if there is such a macro it should be used everywhere or nowhere... > Do you see a need to ever change PREFIX? To be honest: I don't know who would ever need this (me probably not). So the other idea is to carve it out completely? > > Even if it is a reasonable change, the name PREFIX is hopeless. > It would have to be something like ACM_TTYNAME_PREFIX. good point. > > David regards, richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/