Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756069AbaF3MD7 (ORCPT ); Mon, 30 Jun 2014 08:03:59 -0400 Received: from mta-out1.inet.fi ([62.71.2.199]:59702 "EHLO jenni1.inet.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752197AbaF3MD5 (ORCPT ); Mon, 30 Jun 2014 08:03:57 -0400 Date: Mon, 30 Jun 2014 15:03:49 +0300 From: "Kirill A. Shutemov" To: Naoya Horiguchi Cc: linux-mm@kvack.org, Andrew Morton , Dave Hansen , Hugh Dickins , linux-kernel@vger.kernel.org, Naoya Horiguchi Subject: Re: [PATCH v3 06/13] pagemap: use walk->vma instead of calling find_vma() Message-ID: <20140630120349.GV19833@node.dhcp.inet.fi> References: <1403295099-6407-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1403295099-6407-7-git-send-email-n-horiguchi@ah.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403295099-6407-7-git-send-email-n-horiguchi@ah.jp.nec.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 20, 2014 at 04:11:32PM -0400, Naoya Horiguchi wrote: > Page table walker has the information of the current vma in mm_walk, so > we don't have to call find_vma() in each pagemap_hugetlb_range() call. > > NULL-vma check is omitted because we assume that we never run hugetlb_entry() > callback on the address without vma. And even if it were broken, null pointer > dereference would be detected, so we can get enough information for debugging. > > Signed-off-by: Naoya Horiguchi Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/