Message-ID: <53B19A57.2040200@gmail.com>
Date: Mon, 30 Jun 2014 10:11:51 -0700
From: David Daney <ddaney.cavm@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Fabian Frederick <fabf@skynet.be>, Ralf Baechle <ralf@linux-mips.org>
CC: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before
 debugfs_remove_recursive
References: <1404026179-2910-1-git-send-email-fabf@skynet.be>
In-Reply-To: <1404026179-2910-1-git-send-email-fabf@skynet.be>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 06/29/2014 12:16 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

I haven't tested it, but it seems fine, so...

Acked-by: David Daney <david.daney@cavium.com>

> ---
>   arch/mips/cavium-octeon/oct_ilm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/oct_ilm.c b/arch/mips/cavium-octeon/oct_ilm.c
> index 71b213d..2d68a39 100644
> --- a/arch/mips/cavium-octeon/oct_ilm.c
> +++ b/arch/mips/cavium-octeon/oct_ilm.c
> @@ -194,8 +194,7 @@ err_irq:
>   static __exit void oct_ilm_module_exit(void)
>   {
>   	disable_timer(TIMER_NUM);
> -	if (dir)
> -		debugfs_remove_recursive(dir);
> +	debugfs_remove_recursive(dir);
>   	free_irq(OCTEON_IRQ_TIMER0 + TIMER_NUM, 0);
>   }
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/