Date: Mon, 30 Jun 2014 13:39:39 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, joe@perches.com
Subject: Re: [RFC 1/1] proc: constify seq_operations
Message-Id: <20140630133939.c24cd71919cd28c90992d6e1@linux-foundation.org>
In-Reply-To: <1404154997-15490-1-git-send-email-fabf@skynet.be>
References: <1404154997-15490-1-git-send-email-fabf@skynet.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 30 Jun 2014 21:03:17 +0200 Fabian Frederick <fabf@skynet.be> wrote:

> proc_uid_seq_operations, proc_gid_seq_operations and proc_projid_seq_operations
> are only called in proc_id_map_open with seq_open as
> const struct seq_operations so we can constify the 3 structures and update
> proc_id_map_open prototype.

There are an absolutely enormous number of places where we could
constify things.  For sheer sanity's sake I'm not inclined to churn the
code in this way unless a patch provides some sort of runtime benefit. 
And this particular patch doesn't appear to change the generated code
at all.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/