Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754455AbaF3V54 (ORCPT ); Mon, 30 Jun 2014 17:57:56 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:32862 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750836AbaF3V5z (ORCPT ); Mon, 30 Jun 2014 17:57:55 -0400 Date: Mon, 30 Jun 2014 14:57:52 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Keith Busch cc: linux-kernel@vger.kernel.org, Thomas Gleixner , x86@kernel.org Subject: Re: [PATCH] x86: ioapic: Fix irq_free_descs count In-Reply-To: <1404142271-18311-1-git-send-email-keith.busch@intel.com> Message-ID: References: <1404142271-18311-1-git-send-email-keith.busch@intel.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Jun 2014, Keith Busch wrote: > Signed-off-by: Keith Busch > Cc: Thomas Gleixner > Cc: x86@kernel.org Acked-by: David Rientjes This is definitely a fix for "genirq: Provide generic hwirq allocation facility", but the changelog doesn't describe what the problem is and the title that this somehow fixes irq_free_descs() doesn't make any sense. It's the equivalent of just doing - irq_free_descs(from, cnt); + irq_free_descs(from, i - from); I'd suggest the patch title be changed to genirq: Fix memory leak when calling irq_free_hwirqs() and the changelog state irq_free_hwirqs() always calls irq_free_descs() with a cnt == 0 which makes it a no-op since the interrupt count to free is decremented in itself. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/