Date: Mon, 30 Jun 2014 16:15:01 -0600 (MDT)
From: Keith Busch <keith.busch@intel.com>
To: David Rientjes <rientjes@google.com>
cc: Keith Busch <keith.busch@intel.com>, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org
Subject: Re: [PATCH] x86: ioapic: Fix irq_free_descs count
In-Reply-To: <alpine.DEB.2.02.1406301452060.13545@chino.kir.corp.google.com>
Message-ID: <alpine.LRH.2.03.1406301613100.4699@AMR>
References: <1404142271-18311-1-git-send-email-keith.busch@intel.com> <alpine.DEB.2.02.1406301452060.13545@chino.kir.corp.google.com>
User-Agent: Alpine 2.03 (LRH 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 30 Jun 2014, David Rientjes wrote:
> On Mon, 30 Jun 2014, Keith Busch wrote:
>
>> Signed-off-by: Keith Busch <keith.busch@intel.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: x86@kernel.org
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> This is definitely a fix for "genirq: Provide generic hwirq allocation
> facility", but the changelog doesn't describe what the problem is and the
> title that this somehow fixes irq_free_descs() doesn't make any sense.

My mistake, I used the component from the commit I bisected the bug
down to.

> It's the equivalent of just doing
>
> -	irq_free_descs(from, cnt);
> +	irq_free_descs(from, i - from);
>
> I'd suggest the patch title be changed to
>
> 	genirq: Fix memory leak when calling irq_free_hwirqs()
>
> and the changelog state
>
> irq_free_hwirqs() always calls irq_free_descs() with a cnt == 0 which
> makes it a no-op since the interrupt count to free is decremented in
> itself.

Yes, I like your suggestion. Should I submit a v2, or will maintainer
replace the changelog?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/