Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757366AbaGAB4U (ORCPT ); Mon, 30 Jun 2014 21:56:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:34104 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbaGAB4R (ORCPT ); Mon, 30 Jun 2014 21:56:17 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,578,1400050800"; d="scan'208";a="536873472" Message-ID: <1404179763.8366.9.camel@rzhang1-toshiba> Subject: Re: [PATCH] tools/thermal: tmon: fix compilation errors when building statically From: Zhang Rui To: Javi Merino Cc: Jacob Pan , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" Date: Tue, 01 Jul 2014 09:56:03 +0800 In-Reply-To: <20140610151649.GB2798@e104805> References: <1401728897-25188-1-git-send-email-javi.merino@arm.com> <20140602045457.6b519e43@jacob-desktop> <20140610151649.GB2798@e104805> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-06-10 at 16:16 +0100, Javi Merino wrote: > Hi Rui, > > On Mon, Jun 02, 2014 at 12:54:57PM +0100, Jacob Pan wrote: > > On Mon, 2 Jun 2014 18:08:17 +0100 > > "Javi Merino" wrote: > > > > > tmon fails to build statically with the following error: > > > > > > $ make LDFLAGS=-static > > > gcc -O1 -Wall -Wshadow -W -Wformat -Wimplicit-function-declaration > > > -Wimplicit-int -fstack-protector -D VERSION=\"1.0\" -static tmon.o > > > tui.o sysfs.o pid.o -o tmon -lm -lpanel -lncursesw -lpthread > > > tmon.o: In function `tmon_sig_handler': tmon.c:(.text+0x21): > > > undefined reference to `stdscr' tmon.o: In function `tmon_cleanup': > > > tmon.c:(.text+0xb9): undefined reference to `stdscr' > > > tmon.c:(.text+0x11e): undefined reference to `stdscr' > > > tmon.c:(.text+0x123): undefined reference to `keypad' > > > tmon.c:(.text+0x12d): undefined reference to `nocbreak' tmon.o: In > > > function `main': tmon.c:(.text+0x785): undefined reference to `stdscr' > > > tmon.c:(.text+0x78a): undefined reference to `nodelay' > > > tui.o: In function `setup_windows': > > > tui.c:(.text+0x131): undefined reference to `stdscr' > > > tui.c:(.text+0x176): undefined reference to `stdscr' > > > tui.c:(.text+0x19f): undefined reference to `stdscr' > > > tui.c:(.text+0x1cc): undefined reference to `stdscr' > > > tui.c:(.text+0x1ff): undefined reference to `stdscr' > > > tui.o:tui.c:(.text+0x229): more undefined references to `stdscr' > > > follow tui.o: In function `show_cooling_device': > > > [...] > > > > > > stdscr() and friends are in libtinfo (part of ncurses) so add it to > > > the libraries that are linked in when compiling tmon to fix it. > > > > > Acked-by: Jacob Pan > > Thanks! > > Rui, can you pick this up? Done, thanks! -rui > > Cheers, > Javi > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/