Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753246AbaGAHH0 (ORCPT ); Tue, 1 Jul 2014 03:07:26 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:59317 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbaGAHHZ (ORCPT ); Tue, 1 Jul 2014 03:07:25 -0400 Date: Tue, 1 Jul 2014 09:07:20 +0200 From: Sascha Hauer To: Rickard Strandqvist Cc: Linus Walleij , Grant Likely , Rob Herring , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH] pinctrl: pinctrl-imx27.c: Cleaning up remove a struct that is unused Message-ID: <20140701070720.GP14257@pengutronix.de> References: <1403992120-8160-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403992120-8160-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:06:53 up 69 days, 38 min, 50 users, load average: 0.02, 0.09, 0.12 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:5054:ff:fec0:8e10 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 28, 2014 at 11:48:40PM +0200, Rickard Strandqvist wrote: > Removal of a struct that is never used > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist It wasn't even used on the initial commit introducing it. Acked-by: Sascha Hauer Sascha > --- > drivers/pinctrl/pinctrl-imx27.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-imx27.c b/drivers/pinctrl/pinctrl-imx27.c > index 417c992..27ae7ce 100644 > --- a/drivers/pinctrl/pinctrl-imx27.c > +++ b/drivers/pinctrl/pinctrl-imx27.c > @@ -440,12 +440,6 @@ static struct of_device_id imx27_pinctrl_of_match[] = { > { /* sentinel */ } > }; > > -struct imx27_pinctrl_private { > - int num_gpio_childs; > - struct platform_device **gpio_dev; > - struct mxc_gpio_platform_data *gpio_pdata; > -}; > - > static int imx27_pinctrl_probe(struct platform_device *pdev) > { > return imx1_pinctrl_core_probe(pdev, &imx27_pinctrl_info); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/