Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757473AbaGAHWm (ORCPT ); Tue, 1 Jul 2014 03:22:42 -0400 Received: from home.trained-monkey.org ([178.250.213.29]:37023 "EHLO ultrasam.lan.trained-monkey.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752883AbaGAHWk (ORCPT ); Tue, 1 Jul 2014 03:22:40 -0400 X-Greylist: delayed 1271 seconds by postgrey-1.27 at vger.kernel.org; Tue, 01 Jul 2014 03:22:37 EDT From: Jes Sorensen To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Larry Finger , linux-wireless@vger.kernel.org Subject: Re: [PATCH 1/1] staging: rtl8723au: Another case of unnecessary null test before kfree References: <1404028145-4526-1-git-send-email-fabf@skynet.be> Date: Tue, 01 Jul 2014 09:01:45 +0200 In-Reply-To: <1404028145-4526-1-git-send-email-fabf@skynet.be> (Fabian Frederick's message of "Sun, 29 Jun 2014 09:49:05 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fabian Frederick writes: > Fix checkpatch warning: > WARNING: kfree(NULL) is safe this check is probably not required > > Cc: Larry Finger > Cc: Jes Sorensen > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Fabian Frederick > --- > drivers/staging/rtl8723au/core/rtw_ap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c > index c8700b3..8714ae3 100644 > --- a/drivers/staging/rtl8723au/core/rtw_ap.c > +++ b/drivers/staging/rtl8723au/core/rtw_ap.c > @@ -1270,8 +1270,7 @@ static void update_bcn_wps_ie(struct rtw_adapter *padapter) > pnetwork->IELength = wps_offset + (wps_ielen+2) + remainder_ielen; > } > > - if (pbackup_remainder_ie) > - kfree(pbackup_remainder_ie); > + kfree(pbackup_remainder_ie); > } > > static void update_bcn_p2p_ie(struct rtw_adapter *padapter) This one is no longer an issue due to other changes in my tree. Cheers, Jes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/