Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757678AbaGAJ1C (ORCPT ); Tue, 1 Jul 2014 05:27:02 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36849 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753177AbaGAJ1A (ORCPT ); Tue, 1 Jul 2014 05:27:00 -0400 Message-ID: <53B27ED7.4070401@canonical.com> Date: Tue, 01 Jul 2014 17:26:47 +0800 From: Hui Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Jan Kiszka CC: Hui Wang , tiwai@suse.de, alsa-devel@alsa-project.org, alex.hung@canonical.com, yk@canonical.com, david.henningsson@canonical.com, Linux Kernel Mailing List Subject: Re: [V2 PATCH] ALSA: hda - Enable mute/mic-mute LEDs for more Thinkpads with Conexant codec References: <1385534846-20829-1-git-send-email-hui.wang@canonical.com> <53AFF992.5030403@web.de> <53B0C596.6090007@canonical.com> <53B1078B.4090101@web.de> <53B219DF.6090807@canonical.com> <53B26575.1000003@web.de> In-Reply-To: <53B26575.1000003@web.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2014 03:38 PM, Jan Kiszka wrote: > On 2014-07-01 04:15, Hui Wang wrote: >> On 06/30/2014 02:45 PM, Jan Kiszka wrote: >>> On 2014-06-30 04:04, Hui Wang wrote: >>>> On 06/29/2014 07:33 PM, Jan Kiszka wrote: >>>>> On 2013-11-27 07:47, Hui Wang wrote: >>>>>> Most Thinkpad Edge series laptops use conexant codec, so far although >>>>>> >>> Is there anything I can debug or any information I can collect from my >>> box to examine this? >> What is the linux distribution on your machine? And use showkey to catch >> the keycode of that button. > I'm running OpenSUSE 13.1. The reported keycode of the power button is 116. It seems the keycode is correct, it is power keycode rather the mute keycode. Could you please do some debug, let us find which line of code is the root cause for this problem. for example: after running the line, the problem shows up: 1. if (ACPI_SUCCESS(acpi_get_devices("LEN0068", acpi_check_cb, &found, NULL)) && found) // in the sound/pci/hda/thinkpad_helper.c, is_thinkpad() 2. return ACPI_SUCCESS(acpi_get_devices("IBM0068", acpi_check_cb, &found, NULL)) && found; // same as above 3. if (led_set_func(TPACPI_LED_MUTE, false) >= 0) { //in the sound/pci/hda/thinkpad_helper.c, hda_fixup_thinkpad_acpi() 4. if (led_set_func(TPACPI_LED_MICMUTE, false) >= 0) { // same as above > > Jan > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/