Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754911AbaGAJ7n (ORCPT ); Tue, 1 Jul 2014 05:59:43 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:51832 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751273AbaGAJ7m (ORCPT ); Tue, 1 Jul 2014 05:59:42 -0400 Message-ID: <53B28679.1000509@ti.com> Date: Tue, 1 Jul 2014 15:29:21 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Kamil Debski , , , CC: , , Subject: Re: [PATCH] phy: phy-samsung-usb2: Change phy power on/power off sequence References: <1403614495-9291-1-git-send-email-k.debski@samsung.com> In-Reply-To: <1403614495-9291-1-git-send-email-k.debski@samsung.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kamil, On Tuesday 24 June 2014 06:24 PM, Kamil Debski wrote: > The Exynos4412 USB 2.0 PHY hardware differs from the description provided > in the documentation. Some register bits have different function. This > patch fixes the defines of register bits and changes the way how phys are > powered on and off. > > Signed-off-by: Kamil Debski Can you fix these checkpatch warnings? WARNING: space prohibited before semicolon #149: FILE: drivers/phy/phy-exynos4x12-usb2.c:227: + EXYNOS_4x12_URSTCON_HOST_LINK_P1 ; WARNING: line over 80 characters #200: FILE: drivers/phy/phy-exynos4x12-usb2.c:278: + exynos4x12_power_on_internal(&drv->instances[EXYNOS4x12_DEVICE]); WARNING: line over 80 characters #210: FILE: drivers/phy/phy-exynos4x12-usb2.c:288: + exynos4x12_power_on_internal(&drv->instances[EXYNOS4x12_DEVICE]); WARNING: line over 80 characters #220: FILE: drivers/phy/phy-exynos4x12-usb2.c:297: +static void exynos4x12_power_off_internal(struct samsung_usb2_phy_instance *inst) WARNING: line over 80 characters #249: FILE: drivers/phy/phy-exynos4x12-usb2.c:319: + exynos4x12_power_off_internal(&drv->instances[EXYNOS4x12_DEVICE]); WARNING: line over 80 characters #253: FILE: drivers/phy/phy-exynos4x12-usb2.c:323: + exynos4x12_power_off_internal(&drv->instances[EXYNOS4x12_DEVICE]); total: 0 errors, 6 warnings, 182 lines checked Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/