Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754924AbaGAMqB (ORCPT ); Tue, 1 Jul 2014 08:46:01 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:41286 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144AbaGAMp7 (ORCPT ); Tue, 1 Jul 2014 08:45:59 -0400 MIME-Version: 1.0 X-Originating-IP: [89.139.36.201] In-Reply-To: <1398904476-26200-5-git-send-email-s-anna@ti.com> References: <1398904476-26200-1-git-send-email-s-anna@ti.com> <1398904476-26200-5-git-send-email-s-anna@ti.com> From: Ohad Ben-Cohen Date: Tue, 1 Jul 2014 15:45:38 +0300 Message-ID: Subject: Re: [PATCHv5 04/15] hwspinlock/core: add common OF helpers To: Suman Anna Cc: Mark Rutland , Kumar Gala , Tony Lindgren , Josh Cartwright , Bjorn Andersson , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , "devicetree@vger.kernel.org" , linux-arm Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suman, On Thu, May 1, 2014 at 3:34 AM, Suman Anna wrote: > 2. The of_hwspin_lock_simple_xlate() is a simple default > translator function for hwspinlock provider implementations > that use a single cell number for requesting a specific lock > (relatively indexed) within a hwlock bank. Do we have a use case today that require the xlate() method? If not, let's remove it as we could always add it back if some new hardware shows up that needs it. As long as the dt data is unchanged, we should generally only add kernel code that we really need. > 3. The of_hwspin_lock_request_specific() API can be used by > hwspinlock clients to request a specific lock using the > phandle + args specifier. This function relies on the > implementation providing back a relative hwlock id within > the bank from the args specifier. It seems to me we can just introduce a of_hwspin_lock_get_id() method which will provide the global lock id to dt users, with which they could just invoke the existing hwspin_lock_request_specific(). This way we will have more common code between dt users and users who get the lock id from a remote processor. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/