Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758442AbaGASaQ (ORCPT ); Tue, 1 Jul 2014 14:30:16 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:40756 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754995AbaGASaO (ORCPT ); Tue, 1 Jul 2014 14:30:14 -0400 Date: Tue, 1 Jul 2014 14:29:08 -0400 From: "John W. Linville" To: Kees Cook Cc: linux-kernel@vger.kernel.org, Larry Finger , Chaoming Li , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RESEND][PATCH] rtlwifi: btcoexist: avoid format string in printk Message-ID: <20140701182908.GD6358@tuxdriver.com> References: <20140630203849.GA4787@www.outflux.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140630203849.GA4787@www.outflux.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please look in the git trees before reposting patches... commit 6437f51ec36af8ef1e3e2659439b35c37e5498e2 Author: Kees Cook Date: Tue Jun 10 10:37:24 2014 -0700 rtlwifi: btcoexist: avoid format string in printk Since CL_PRINTF only ever takes a single argument, make sure a format string cannot leak into printk. Signed-off-by: Kees Cook Signed-off-by: John W. Linville On Mon, Jun 30, 2014 at 01:38:49PM -0700, Kees Cook wrote: > Since CL_PRINTF only ever takes a single argument, make sure a format > string cannot leak into printk. > > Signed-off-by: Kees Cook > --- > .../net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h b/drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h > index 871fc3c6d559..049f4c8d98a8 100644 > --- a/drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h > +++ b/drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.h > @@ -114,7 +114,7 @@ extern u32 btc_dbg_type[]; > > > #define CL_SPRINTF snprintf > -#define CL_PRINTF printk > +#define CL_PRINTF(buf) printk("%s", buf) > > #define BTC_PRINT(dbgtype, dbgflag, printstr, ...) \ > do { \ > -- > 1.7.9.5 > > > -- > Kees Cook > Chrome OS Security > -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/