Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756931AbaGATTi (ORCPT ); Tue, 1 Jul 2014 15:19:38 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:34742 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbaGATTh (ORCPT ); Tue, 1 Jul 2014 15:19:37 -0400 Date: Tue, 01 Jul 2014 12:19:35 -0700 (PDT) Message-Id: <20140701.121935.729962585105477131.davem@davemloft.net> To: joe@perches.com Cc: pcnet32@frontier.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH V2] pcnet32: Neaten and remove unnecessary OOM messages From: David Miller In-Reply-To: <1403740525.28663.6.camel@joe-AO725> References: <1403550950.15811.15.camel@joe-AO725> <1403557507.20657.3.camel@joe-AO725> <1403740525.28663.6.camel@joe-AO725> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Jul 2014 12:19:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Wed, 25 Jun 2014 16:55:25 -0700 > Make the code flow a little better for 80 columns. > > Use a consistent style for the RX and TX rings allocation. > Use BIT macro. > Use a temporary unsigned int entries for (1< Remove the OOM messages as they duplicate the generic > OOM and dump_stack() provided by the memory subsystem. > Reflow allocs to 80 columns. > > Signed-off-by: Joe Perches > Acked-by: Don Fry > --- > V2: Use pcnet32 as patch prefix, amd is too generic > > Still depends on patch 1/22: pci-dma-compat: Add pci_zalloc_consistent helper If this has a dependency on a patch I'm not added to my tree, I'm not applying this one either. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/