Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030342AbaGAWVj (ORCPT ); Tue, 1 Jul 2014 18:21:39 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:46416 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759047AbaGAWVY (ORCPT ); Tue, 1 Jul 2014 18:21:24 -0400 Date: Tue, 1 Jul 2014 15:21:21 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Joonsoo Kim cc: Andrew Morton , Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vladimir Davydov Subject: Re: [PATCH v3 2/9] slab: move up code to get kmem_cache_node in free_block() In-Reply-To: <1404203258-8923-3-git-send-email-iamjoonsoo.kim@lge.com> Message-ID: References: <1404203258-8923-1-git-send-email-iamjoonsoo.kim@lge.com> <1404203258-8923-3-git-send-email-iamjoonsoo.kim@lge.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Jul 2014, Joonsoo Kim wrote: > node isn't changed, so we don't need to retreive this structure > everytime we move the object. Maybe compiler do this optimization, > but making it explicitly is better. > Qualifying the pointer as const would be even more explicit. > Acked-by: Christoph Lameter > Signed-off-by: Joonsoo Kim Acked-by: David Rientjes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/