Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756967AbaGBFfX (ORCPT ); Wed, 2 Jul 2014 01:35:23 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:39914 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754593AbaGBFfV (ORCPT ); Wed, 2 Jul 2014 01:35:21 -0400 MIME-Version: 1.0 In-Reply-To: <8738ek5qyh.fsf@sejong.aot.lge.com> References: <1403913966-4927-1-git-send-email-ast@plumgrid.com> <1403913966-4927-2-git-send-email-ast@plumgrid.com> <8738ek5qyh.fsf@sejong.aot.lge.com> Date: Tue, 1 Jul 2014 22:35:20 -0700 Message-ID: Subject: Re: [PATCH RFC net-next 01/14] net: filter: split filter.c into two files From: Alexei Starovoitov To: Namhyung Kim Cc: "David S. Miller" , Ingo Molnar , Linus Torvalds , Steven Rostedt , Daniel Borkmann , Chema Gonzalez , Eric Dumazet , Peter Zijlstra , Arnaldo Carvalho de Melo , Jiri Olsa , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , Kees Cook , Linux API , Network Development , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 1, 2014 at 9:23 PM, Namhyung Kim wrote: > Hi Alexei, > > On Fri, 27 Jun 2014 17:05:53 -0700, Alexei Starovoitov wrote: >> BPF is used in several kernel components. This split creates logical boundary >> between generic eBPF core and the rest >> >> kernel/bpf/core.c: eBPF interpreter >> >> net/core/filter.c: classic->eBPF converter, classic verifiers, socket filters >> >> This patch only moves functions. >> >> Signed-off-by: Alexei Starovoitov >> --- >> kernel/Makefile | 1 + >> kernel/bpf/Makefile | 1 + >> kernel/bpf/core.c | 545 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> net/core/filter.c | 520 ------------------------------------------------ >> 4 files changed, 547 insertions(+), 520 deletions(-) >> create mode 100644 kernel/bpf/Makefile >> create mode 100644 kernel/bpf/core.c >> >> diff --git a/kernel/Makefile b/kernel/Makefile >> index f2a8b6246ce9..e7360b7c2c0e 100644 >> --- a/kernel/Makefile >> +++ b/kernel/Makefile >> @@ -87,6 +87,7 @@ obj-$(CONFIG_RING_BUFFER) += trace/ >> obj-$(CONFIG_TRACEPOINTS) += trace/ >> obj-$(CONFIG_IRQ_WORK) += irq_work.o >> obj-$(CONFIG_CPU_PM) += cpu_pm.o >> +obj-$(CONFIG_NET) += bpf/ > > But this still requires CONFIG_NET to use bpf. Why not adding > CONFIG_BPF and making CONFIG_NET selects it? This is the first patch that does 'split only'. Later patch replaces this line with CONFIG_BPF. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/