Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbaGBL6T (ORCPT ); Wed, 2 Jul 2014 07:58:19 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:34806 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbaGBL6S (ORCPT ); Wed, 2 Jul 2014 07:58:18 -0400 Message-ID: <53B3F3B1.2030807@ti.com> Date: Wed, 2 Jul 2014 17:27:37 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Lee Jones CC: , , Subject: Re: [PATCH v2 4/5] phy: miphy365x: Represent each PHY channel as a subnode References: <1404133317-25953-1-git-send-email-lee.jones@linaro.org> <1404133317-25953-5-git-send-email-lee.jones@linaro.org> <20140630144114.GB25926@lee--X1> <53B3DE4F.1040100@ti.com> <20140702113428.GA16724@lee--X1> In-Reply-To: <20140702113428.GA16724@lee--X1> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 02 July 2014 05:04 PM, Lee Jones wrote: >> On Monday 30 June 2014 08:11 PM, Lee Jones wrote: >>> phy: miphy365x: Represent each PHY channel as a DT subnode >>> >>> This has the added advantages of being able to enable/disable each >>> of the channels as simply as enabling/disabling the DT node. >>> >>> Suggested-by: Kishon Vijay Abraham I >>> Signed-off-by: Lee Jones >>> >>> diff --git a/drivers/phy/phy-miphy365x.c b/drivers/phy/phy-miphy365x.c >>> index 1109f42..2c4ea6e 100644 >>> --- a/drivers/phy/phy-miphy365x.c >>> +++ b/drivers/phy/phy-miphy365x.c > > [...] > >>> -static int miphy365x_of_probe(struct device_node *np, >>> +static int miphy365x_of_probe(struct platform_device *pdev, >>> struct miphy365x_dev *phy_dev) >>> { >>> + struct device_node *np = pdev->dev.of_node; >>> + struct device_node *child; >>> + int child_count = 0; >>> + >>> + for_each_child_of_node(np, child) >>> + child_count++; >> >> use of_get_child_count() instead. > > Ah, nice. I'll do that. > > [...] > >> I think you can merge this to your original patch. > > I can do that, but I thought It'd be nice to keep some history and > show the migration over to a different setup. This is particularly > important for when we back-port the changes back into the internal > development kernel. cool.. i'm fine with it. Cheers Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/