Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbaGBMCp (ORCPT ); Wed, 2 Jul 2014 08:02:45 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:33338 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750991AbaGBMCo (ORCPT ); Wed, 2 Jul 2014 08:02:44 -0400 Date: Wed, 2 Jul 2014 13:02:38 +0100 From: Lee Jones To: Kishon Vijay Abraham I Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com Subject: Re: [PATCH 2/5] phy: miphy365x: Add MiPHY365x header file for DT x Driver defines Message-ID: <20140702120238.GC16724@lee--X1> References: <1404133317-25953-1-git-send-email-lee.jones@linaro.org> <1404133317-25953-3-git-send-email-lee.jones@linaro.org> <53B3D0BE.9090708@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <53B3D0BE.9090708@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Jul 2014, Kishon Vijay Abraham I wrote: > On Monday 30 June 2014 06:31 PM, Lee Jones wrote: > > This provides the shared header file which will be reference from both > > the MiPHY365x driver and its associated Device Tree node(s). > > > > Cc: Kishon Vijay Abraham I > > Acked-by: Mark Rutland > > Acked-by: Alexandre Torgue > > Signed-off-by: Lee Jones > > --- > > include/dt-bindings/phy/phy-miphy365x.h | 25 +++++++++++++++++++++++++ > > 1 file changed, 25 insertions(+) > > create mode 100644 include/dt-bindings/phy/phy-miphy365x.h [...] > > +#define MIPHY_SATA_PORT0 (MIPHY_TYPE_SATA) | (MIPHY_PORT_0) > > +#define MIPHY_SATA_PORT1 (MIPHY_TYPE_SATA) | (MIPHY_PORT_1) > > +#define MIPHY_PCIE_PORT0 (MIPHY_TYPE_PCIE) | (MIPHY_PORT_0) > > +#define MIPHY_PCIE_PORT1 (MIPHY_TYPE_PCIE) | (MIPHY_PORT_1) > > As Sergei pointed in your previous version it should be (X | Y). Hmm, yes. I even have his email marked as 'important' and to fix that up. Sorry about that, will fix. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/