Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753826AbaGBOUZ (ORCPT ); Wed, 2 Jul 2014 10:20:25 -0400 Received: from qmta13.emeryville.ca.mail.comcast.net ([76.96.27.243]:37258 "EHLO qmta13.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbaGBOUY (ORCPT ); Wed, 2 Jul 2014 10:20:24 -0400 Date: Wed, 2 Jul 2014 09:20:20 -0500 (CDT) From: Christoph Lameter To: Wei Yang cc: David Rientjes , Sasha Levin , Pekka Enberg , Matt Mackall , Andrew Morton , "linux-mm@kvack.org" , LKML , Dave Jones Subject: Re: mm: slub: invalid memory access in setup_object In-Reply-To: <20140702020454.GA6961@richard> Message-ID: References: <53AAFDF7.2010607@oracle.com> <20140702020454.GA6961@richard> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Jul 2014, Wei Yang wrote: > My patch is somewhat convoluted since I wanted to preserve the original logic > and make minimal change. And yes, it looks not that nice to audience. Well I was the author of the initial "convoluted" logic. > I feel a little hurt by this patch. What I found and worked is gone with this > patch. Ok how about giving this one additional revision. Maybe you can make the function even easier to read? F.e. the setting of the NULL pointer at the end of the loop is ugly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/