Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755758AbaGBQHd (ORCPT ); Wed, 2 Jul 2014 12:07:33 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:50004 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638AbaGBQHb (ORCPT ); Wed, 2 Jul 2014 12:07:31 -0400 MIME-Version: 1.0 In-Reply-To: <20140702154828.GO19781@tassilo.jf.intel.com> References: <1403910612-8754-1-git-send-email-andi@firstfloor.org> <1403910612-8754-2-git-send-email-andi@firstfloor.org> <20140702153300.GM19781@tassilo.jf.intel.com> <20140702154828.GO19781@tassilo.jf.intel.com> Date: Wed, 2 Jul 2014 18:07:31 +0200 Message-ID: Subject: Re: [PATCH 1/2] perf, x86: Revamp PEBS event selection From: Stephane Eranian To: Andi Kleen Cc: Andi Kleen , Peter Zijlstra , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 2, 2014 at 5:48 PM, Andi Kleen wrote: > On Wed, Jul 02, 2014 at 05:44:05PM +0200, Stephane Eranian wrote: >> On Wed, Jul 2, 2014 at 5:33 PM, Andi Kleen wrote: >> >> No, still needs to be INTEL_ALL_EVENT_CONSTRAINT(0x0, 0x1) >> >> otherwise the get_event_constraint() test I mentioned previously will >> >> fail, event with your ALL_FILTER mask. >> > >> > What events should fail? I verified all PEBS events and they work as expected. >> > >> Random events should not fail, they should go with precise and not generate >> any samples. That's the whole point of the exercise. >> >> perf record -a -e r6099:p sleep 1 > > Like I said I ran all PEBS events and they generated samples. > I understand. I ran some random events to make sure I was not getting PEBS samples and the system was stable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/