Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756672AbaGBR0i (ORCPT ); Wed, 2 Jul 2014 13:26:38 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:49624 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751540AbaGBR0h (ORCPT ); Wed, 2 Jul 2014 13:26:37 -0400 Date: Wed, 2 Jul 2014 19:26:20 +0200 From: Emil Goode To: Greg Kroah-Hartman Cc: Rashika Kheria , Valentina Manea , Josh Triplett , Andrea Merello , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8192e: Fix potential NULL pointer dereference Message-ID: <20140702172620.GA4848@lianli> References: <1404293151-15804-1-git-send-email-emilgoode@gmail.com> <20140702163334.GA19349@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140702163334.GA19349@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg, On Wed, Jul 02, 2014 at 09:33:34AM -0700, Greg Kroah-Hartman wrote: > On Wed, Jul 02, 2014 at 11:25:51AM +0200, Emil Goode wrote: > > We need to make sure the struct rtllib_device pointer ieee is not NULL > > after the goto rx_dropped label since it is dereferenced there. > > > > Signed-off-by: Emil Goode > > --- > > drivers/staging/rtl8192e/rtllib_rx.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c > > index 60de54c..7db3e74 100644 > > --- a/drivers/staging/rtl8192e/rtllib_rx.c > > +++ b/drivers/staging/rtl8192e/rtllib_rx.c > > @@ -1496,7 +1496,8 @@ int rtllib_rx(struct rtllib_device *ieee, struct sk_buff *skb, > > return ret; > > > > rx_dropped: > > - ieee->stats.rx_dropped++; > > + if (ieee) > > + ieee->stats.rx_dropped++; > > return 0; > > } > > EXPORT_SYMBOL(rtllib_rx); > > Is this something that is hitting users today in the tree, or is this > just a bug you found looking at the code? It's a static checker fix and I'm not aware of any impact on users. If you want I will resend with that information added? Best regards, Emil Goode -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/