Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757264AbaGBS3z (ORCPT ); Wed, 2 Jul 2014 14:29:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53470 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbaGBS3y (ORCPT ); Wed, 2 Jul 2014 14:29:54 -0400 Date: Wed, 2 Jul 2014 14:29:05 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Christoph Hellwig cc: Sagi Grimberg , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Christie , Nicholas Bellinger Subject: Re: Crash on WRITE SAME In-Reply-To: <20140702181333.GA15792@infradead.org> Message-ID: References: <20140702181333.GA15792@infradead.org> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Jul 2014, Christoph Hellwig wrote: > On Wed, Jul 02, 2014 at 02:05:14PM -0400, Mikulas Patocka wrote: > > Hi Sagi > > > > Your commit d77e65350f2d82dfa0557707d505711f5a43c8fd causes crash on SCSI > > WRITE SAME command (it can be triggered by issuing the BLKZEROOUT ioctl). > > The crash happens in iscsi_tcp_segment_done because sg_next returns NULL. > > Martin already fixes this over a week ago, we're just waiting for James > to send a pull request to Linus. > > Get this fix from the core-for-3.16 branch of > git.infradead.org/users/hch/scsi-queue.git for now. I see. And what about protection information for commands that transfer partial sectors? (for example, UMAP transfers 24 bytes). Should scsi_transfer_length return 24 or 32 in this case? Mikulas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/