Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932251AbaGBVoJ (ORCPT ); Wed, 2 Jul 2014 17:44:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30447 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754947AbaGBVoI (ORCPT ); Wed, 2 Jul 2014 17:44:08 -0400 Date: Wed, 2 Jul 2014 17:38:57 -0400 From: Luiz Capitulino To: David Rientjes Cc: Andrew Morton , Joonsoo Kim , Naoya Horiguchi , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm, hugetlb: remove hugetlb_zero and hugetlb_infinity Message-ID: <20140702173857.08dff9fc@redhat.com> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Jun 2014 17:46:35 -0700 (PDT) David Rientjes wrote: > They are unnecessary: "zero" can be used in place of "hugetlb_zero" and > passing extra2 == NULL is equivalent to infinity. > > Signed-off-by: David Rientjes Reviewed-by: Luiz Capitulino > --- > include/linux/hugetlb.h | 1 - > kernel/sysctl.c | 9 +++------ > mm/hugetlb.c | 1 - > 3 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -86,7 +86,6 @@ pte_t *huge_pmd_share(struct mm_struct *mm, unsigned long addr, pud_t *pud); > #endif > > extern unsigned long hugepages_treat_as_movable; > -extern const unsigned long hugetlb_zero, hugetlb_infinity; > extern int sysctl_hugetlb_shm_group; > extern struct list_head huge_boot_pages; > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -1240,8 +1240,7 @@ static struct ctl_table vm_table[] = { > .maxlen = sizeof(unsigned long), > .mode = 0644, > .proc_handler = hugetlb_sysctl_handler, > - .extra1 = (void *)&hugetlb_zero, > - .extra2 = (void *)&hugetlb_infinity, > + .extra1 = &zero, > }, > #ifdef CONFIG_NUMA > { > @@ -1250,8 +1249,7 @@ static struct ctl_table vm_table[] = { > .maxlen = sizeof(unsigned long), > .mode = 0644, > .proc_handler = &hugetlb_mempolicy_sysctl_handler, > - .extra1 = (void *)&hugetlb_zero, > - .extra2 = (void *)&hugetlb_infinity, > + .extra1 = &zero, > }, > #endif > { > @@ -1274,8 +1272,7 @@ static struct ctl_table vm_table[] = { > .maxlen = sizeof(unsigned long), > .mode = 0644, > .proc_handler = hugetlb_overcommit_handler, > - .extra1 = (void *)&hugetlb_zero, > - .extra2 = (void *)&hugetlb_infinity, > + .extra1 = &zero, > }, > #endif > { > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -35,7 +35,6 @@ > #include > #include "internal.h" > > -const unsigned long hugetlb_zero = 0, hugetlb_infinity = ~0UL; > unsigned long hugepages_treat_as_movable; > > int hugetlb_max_hstate __read_mostly; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/