Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753591AbaGBWo3 (ORCPT ); Wed, 2 Jul 2014 18:44:29 -0400 Received: from sabe.cs.wisc.edu ([128.105.6.20]:54978 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752654AbaGBWo1 (ORCPT ); Wed, 2 Jul 2014 18:44:27 -0400 Message-ID: <53B48B37.4000608@cs.wisc.edu> Date: Wed, 02 Jul 2014 17:44:07 -0500 From: Mike Christie User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130917 Thunderbird/17.0.9 MIME-Version: 1.0 To: Alex Williamson CC: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sagi Grimberg , Nicholas Bellinger , SCSI Mailing List Subject: Re: [PATCH 3.15 099/139] libiscsi, iser: Adjust data_length to include protection information References: <20140628174605.352098823@linuxfoundation.org> <20140628174609.930049472@linuxfoundation.org> <1404339330.1862.69.camel@ul30vt.home> In-Reply-To: <1404339330.1862.69.camel@ul30vt.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/2014 05:15 PM, Alex Williamson wrote: > On Sat, 2014-06-28 at 10:47 -0700, Greg Kroah-Hartman wrote: >> > 3.15-stable review patch. If anyone has any objections, please let me know. >> > >> > ------------------ >> > >> > From: Sagi Grimberg >> > >> > commit d77e65350f2d82dfa0557707d505711f5a43c8fd upstream. >> > >> > In case protection information exists over the wire >> > iscsi header data length is required to include it. >> > Use protection information aware scsi helpers to set >> > the correct transfer length. >> > >> > In order to avoid breakage, remove iser transfer length >> > checks for each task as they are not always true and >> > somewhat redundant anyway. >> > >> > Signed-off-by: Sagi Grimberg >> > Reviewed-by: Mike Christie >> > Acked-by: Mike Christie >> > Signed-off-by: Nicholas Bellinger >> > Signed-off-by: Greg Kroah-Hartman >> > >> > --- >> > drivers/infiniband/ulp/iser/iser_initiator.c | 34 +++++++-------------------- >> > drivers/scsi/libiscsi.c | 18 +++++++------- >> > 2 files changed, 19 insertions(+), 33 deletions(-) > I'm a bit late to object, but this is causing a regression for me on > 3.15.3 and 3.16-rc. Using an iscsi_tcp rootfs, I'm seeing the NULL A fix for this is in Christoph's tree. Here is the status of the patch. http://marc.info/?l=linux-kernel&m=140432482527273&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/