Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751070AbaGCIdi (ORCPT ); Thu, 3 Jul 2014 04:33:38 -0400 Received: from smtp-out-164.synserver.de ([212.40.185.164]:1097 "EHLO smtp-out-164.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbaGCIdg (ORCPT ); Thu, 3 Jul 2014 04:33:36 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 23798 Message-ID: <53B5155E.7050103@metafoo.de> Date: Thu, 03 Jul 2014 10:33:34 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.6.0 MIME-Version: 1.0 To: Peter Ujfalusi , vinod.koul@intel.com, dan.j.williams@intel.com, tiwai@suse.de, Mark Brown , Liam Girdwood , joelf@ti.com, nsekhar@ti.com CC: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, dmaengine@vger.kernel.org Subject: Re: [PATCH v3 0/5] ALSA/ASoC/dmaengine: Fix 3 bytes physical sample support References: <1404363116-10538-1-git-send-email-peter.ujfalusi@ti.com> In-Reply-To: <1404363116-10538-1-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2014 06:51 AM, Peter Ujfalusi wrote: [...] > > First step is to add DMA_SLAVE_BUSWIDTH_3_BYTES to dma_slave_buswidth for > engines and users to select 3 bytes as bus width. > > Followed by: > In dmaengine_pcm_set_runtime_hwparams() we should check the slave_caps of the > dma if it supports the give sample physical width of the sample. Based on this > information we initialize the hw.formats: masking out all non supported formats > based on the physical width. > In case the dma driver does not implement the slave_caps the default assumption > is that it supports 1, 2 and 4 bytes widths. The whole series looks good to me. Since both the DMA and ALSA bits changed in this series are fairly trivial I think it is best to merge the whole series through the ASoC tree. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/