Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932411AbaGCKMm (ORCPT ); Thu, 3 Jul 2014 06:12:42 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.160]:58544 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932261AbaGCKMj (ORCPT ); Thu, 3 Jul 2014 06:12:39 -0400 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWi/zfN1cLnBYfssBY9SQMKk8kCovkkmJbh+VP2spQG3tvMeGW7W X-RZG-CLASS-ID: mo00 Date: Thu, 3 Jul 2014 12:12:33 +0200 From: Olaf Hering To: Jiri Slaby Cc: linux-kernel@vger.kernel.org, Jiri Kosina Subject: Re: [PATCH 3.12 13/72] floppy: bail out in open() if drive is not responding to block0 read Message-ID: <20140703101233.GA28675@aepfle.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22.rev6346 (2013-10-29) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 18, Jiri Slaby wrote: > From: Jiri Kosina > commit 7b7b68bba5ef23734c35ffb0d8d82079ed604d33 upstream. > +static void floppy_rb0_cb(struct bio *bio, int err) > { > - complete((struct completion *)bio->bi_private); > + struct rb0_cbdata *cbdata = (struct rb0_cbdata *)bio->bi_private; > + int drive = cbdata->drive; > + > + if (err) { > + pr_info("floppy: error %d while reading block 0", err); This change lacks a newline... Olaf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/